https://gitlab.synchro.net/sbbs/sbbs/-/commit/39a77d9acafccfee0dd178ae
Modified Files:
src/sbbs3/getstats.c
Log Message:
For subs that allow voting, getposts() will exclude vote messages from total.

Vote messages and poll closures are not displayed to users as messages, so exclude them from the total "posts" returned from getposts(). This uses
the new smb_msg_count() function which is slower than simply checking the
size of the index file (*.sid) and dividing by the index record size. So
for sub-boards that don't support voting, use the old/faster scheme.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1d8e2cc427c4da99e44fd861
Modified Files:
src/sbbs3/getstats.c
Log Message:
Fix the sbbs.h dependency unintentionally left after c_dep_refactor
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/da2177b75997fcb7b00b0bf7
Modified Files:
src/sbbs3/getstats.c
Log Message:
Add TODO comment about dsts.dab not tracking > 4GB up/downloads
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f609ac6ce9e3cbe09dd500fd
Modified Files:
src/sbbs3/getstats.c
Log Message:
Use fnopen() in fopen_dstats() to get open auto-retries

iniFileOpen() does not perform retries and there can be contention for the ctrl/dsts.ini file.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/dc4d9eb9f723cdf5cbdd1915
Modified Files:
src/sbbs3/getstats.c
Log Message:
Don't log an error if there's no dsts.ini or dsts.dab file

In a fresh install, neither of these files would exist, and that's normal,
so getstats() should just return true in that case (with the stats struct zeroed-out).

Fixes error during login to a new install reported by Zolt n G bor on
Facebook.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5518bddb66f26e915b44d911
Modified Files:
src/sbbs3/getstats.c
Log Message:
Fix return value of fclose_dstats - not currently checked anywhere

fclose() returns 0 on success.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/49027a4c86062a4fd6d2588b
Modified Files:
src/sbbs3/getstats.c
Log Message:
Fix comment header for putstats() - copy/pasted from getstats()
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/289577c6948e58ae0ee49fbc
Modified Files:
src/sbbs3/getstats.c
Log Message:
In debug builds only, backup dsts.ini file when opening for write

Hopefully help to determine cause of issue #791 (when is the apparent corruption of this file occurring?)
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c8cfd95ba7e06f45c62eb03e
Modified Files:
src/sbbs3/getstats.c
Log Message:
Non-functional changes

iniWriteFile() returns bool, not int.

Removed inapplicable function comment.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f4d4eaad66b52f5cf3309c44
Modified Files:
src/sbbs3/getstats.c
Log Message:
fread_dstats() will now return false upon file read failure

The file position should always be at the EOF after reading the contents.

This should help detect (log errors) upon potential cause of issue #791.

- use a little easier to read .ini style
- add a NULL argument check to local function write_dstats()
return false rather than deref the NULL pointer
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cd049a4e9354a5505d5455ff
Modified Files:
src/sbbs3/getstats.c
Log Message:
Don't update/rewrite dsts.ini when iniReadFile returns NULL

Even if the empty, iniReadFile() should return an empty list (not NULL),
NULL indicates a file read (or unlikely malloc failure) - so don't write back what we read and return false (result) instead.

Part of likely work-around of issue #791: it's better to not increment stats upon a file read error than to reset them all to zero.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/aa1b62266da07a18b3850b0c
Modified Files:
src/sbbs3/getstats.c
Log Message:
Don't backup the dsts.ini file when saving changes, not needed any more

Root-caused this problem to read() failures which are now caught and logged rather than zeroing out the statistics fields.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ff7d388c5a671aa9d07a2267
Modified Files:
src/sbbs3/getstats.c
Log Message:
Don't indent the Date key in the root section
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net