Because the test to continue is *after* the loop, we can't continue
when c is the last index into lzh->son, or the code will make use of lzh->son[sizeof(lzh->son)/sizeof(lzh->son[0])] which is outside the bounds
of the array.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
From deuce@VERT to CVS commit on Wed Apr 15 10:54:55 2020
src/encode lzh.c 1.14 1.15
Update of /cvsroot/sbbs/src/encode
In directory cvs:/tmp/cvs-serv688
Modified Files:
lzh.c
Log Message:
More weirdness uncovered by Coverity.
To be fair, this is all weird.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
From deuce@VERT to CVS commit on Fri Apr 17 07:08:11 2020
src/encode lzh.c 1.15 1.16
Update of /cvsroot/sbbs/src/encode
In directory cvs:/tmp/cvs-serv1738
Modified Files:
lzh.c
Log Message:
I'm going to get the LZH to pass Coverity if it's the last thing I do!
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
Who's Online
System Info
Sysop:
deepend
Location:
Calgary, Alberta
Users:
240
Nodes:
10 (0
/
10)
Uptime:
05:26:46
Calls:
1,460
Files:
3,364
Messages:
359,407
Synchronet Oneliners
Vintagegeek@rdbbs Wed Apr 24 06:18:54 2024 Greetings Lone Star State
Vintagegeek@rdbbs Fri Apr 26 05:27:11 2024 Running out of energy. Coffee Time
Vintagegeek@rdbbs Sun Apr 28 05:40:04 2024 go giants
Vintagegeek@rdbbs Sun Apr 28 13:42:10 2024 Go Phillies
Vintagegeek@rdbbs Mon Apr 29 04:53:15 2024 Go Canucks
Vintagegeek@rdbbs Wed May 1 05:32:11 2024 Oh God Its already May